Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split Sumcheck #245

Closed
wants to merge 2 commits into from
Closed

Split Sumcheck #245

wants to merge 2 commits into from

Conversation

adr1anh
Copy link
Contributor

@adr1anh adr1anh commented Mar 15, 2023 •
edited
Loading

Description

Sumcheck

  • Both parties now return a SumcheckOutput so that the evaluations and opening point do not need to be re-read from the transcript
  • Remove alpha and zeta from RelationParameters
  • Remove constructors in favor of passing arguments directly to the prover/verifier.
  • Verifier is implemented completely in Sumcheck and no longer depends on SumcheckRound.
  • Sumcheck and SumcheckRound are static. Parameters are passed explicitly to functions to show what is modified and ensure constness.
  • renamed fold to partially_evaluate and make all Sumcheck rounds uniform for the prover. (no more special case for the first round)
  • temporary buffers for partially evaluated polynomials are now created in execute_prover
  • Added method for evaluating the full Honk identity

Honk Prover/Verifier

  • Clean up types to make things a bit more generic
  • Move challenge extraction in ways which will make the transcript work easier

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR specifications in /markdown/specs have been updated.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • I've updated any terraform that needs updating (e.g. environment variables) for deployment.
  • The branch has been rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.

adr1anh added 2 commits March 15, 2023 16:07
@adr1anh
- Remove zeta,alpha from relation_params
bba1601 
- make sumcheck methods static
- add public inputs and rel_param to prover key
- sumcheck returns an output
- sumcheck verifier does not depend on sumcheck round
@adr1anh
fix build
f45669b
@codygunton
Copy link
Collaborator

Some of this work was completed in #248. The rest is not currently planned.

@codygunton codygunton closed this Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@adr1anh adr1anh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adr1anh @codygunton